Eli Mesika has posted comments on this change. Change subject: <WIP>engine: support for external event handlers ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25270/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/events/ExternalEventHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/events/ExternalEventHandler.java: Line 5: public interface ExternalEventHandler { Line 6: Line 7: void handleEvent(AuditLog event); Line 8: Line 9: boolean canHandleEvent(AuditLog event); What is the usage of that? I see it is returning true in all implementations , can we just state that each handler handles all events passed to it for simplicity ??? Can you give an example when this is implemented and returning false ? -- To view, visit http://gerrit.ovirt.org/25270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9c8638fbc8794cc196134093af9ff7e7cb4876 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
