Martin Betak has posted comments on this change. Change subject: frontend: Enable configuration of Serial Number ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/25101/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.java: Line 21: Line 22: interface Driver extends SimpleBeanEditorDriver<SerialNumberPolicyModel, SerialNumberPolicyWidget> { Line 23: } Line 24: Line 25: private Driver driver = GWT.create(Driver.class); > Please mark "driver" as final. Done Line 26: Line 27: interface ViewUiBinder extends UiBinder<FlowPanel, SerialNumberPolicyWidget> { Line 28: ViewUiBinder uiBinder = GWT.create(ViewUiBinder.class); Line 29: } Line 35: interface Style extends CssResource { Line 36: String serialNumberPolicy(); Line 37: } Line 38: Line 39: public SerialNumberPolicyWidget(EventBus eventBus) { > Please consider moving constructor below field declarations (i.e. @UiField Done Line 40: serialNumberPolicy = new EnumRadioEditor<SerialNumberPolicy>(SerialNumberPolicy.class, eventBus); Line 41: serialNumberPolicy.addValueChangeHandler(this); Line 42: Line 43: initWidget(ViewUiBinder.uiBinder.createAndBindUi(this)); Line 36: String serialNumberPolicy(); Line 37: } Line 38: Line 39: public SerialNumberPolicyWidget(EventBus eventBus) { Line 40: serialNumberPolicy = new EnumRadioEditor<SerialNumberPolicy>(SerialNumberPolicy.class, eventBus); > Hm, so if I understand correctly, we're passing EventBus to EnumRadioEditor Yes, this could be a good improvement but I would suggest it as a separate change. This patchset is already too big. Line 41: serialNumberPolicy.addValueChangeHandler(this); Line 42: Line 43: initWidget(ViewUiBinder.uiBinder.createAndBindUi(this)); Line 44: driver.initialize(this); -- To view, visit http://gerrit.ovirt.org/25101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7064570c2d66fdd473c31214892867b8b9b67a21 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
