Vojtech Szocs has posted comments on this change. Change subject: frontend: Enable configuration of Serial Number ......................................................................
Patch Set 4: (1 comment) Just one small comment in CommonApplicationMessages.java - otherwise looking good. http://gerrit.ovirt.org/#/c/25101/4/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java: Line 150: @DefaultMessage("Hot set CPUs by changing the number of sockets." + Line 151: " The support for hot plug/unplug CPUs to the guest varies.") Line 152: String hotPlugUnplugCpuWarning(); Line 153: Line 154: @DefaultMessage("Policy of assigning serial numbers to running VMs. Can be Host\'s UUID, Vm\'s UUID or any custom value.") Please use: .. Host''s UUID .. Vm''s UUID .. to comply with Java MessageFormat as specified in @DefaultMessage annotation: A single quote itself must be represented by doubled single quotes '' throughout a String. Line 155: String serialNumberInfo(); -- To view, visit http://gerrit.ovirt.org/25101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7064570c2d66fdd473c31214892867b8b9b67a21 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
