Moti Asayag has posted comments on this change.
Change subject: engine: Collect stats based on non-operational reason
......................................................................
Patch Set 4:
Moving the discussion here from the commit message:
> Omer Frenkel Mar 2 4:22 PM
>
>what is the difference in activate of user / Auto-Recovery? it should be the
>same flow, and will solve this as well
>
>
> Moti Asayag Mar 3 12:20 PM
>
>While activating the host - the nics status isn't being >examined. Host
>activation invokes getVdsCaps - only >detects missing networks Host monitoring
>invokes getStats >- detects the nics status
>
>We used to have a bug that the auto-recovery would flap >host status from up
>to non-operational. As part of that >bug be no longer activate hosts that has
>a problematic >nics.
>
>But without invoking getStats, the nics status will not be >updated. That's
>why the logic between the auto-recovery to >activate is a bit different. You
>could claim however that >if the getStas reports a problematic nics, no need
>to >activate the host since it will end up as non-operational >(meaning only
>when activating non-operational hosts), but >this will require the same fix as
>this patch suggests.
>
>
> Omer Frenkel 11:03 AM
>
>so it sounds like the solution to that bug was incorrect.. >we should have one
>way how this works, dividing into >special cases is not a good practice. can
>we review other >solutions to that other bug with the auto recovery?
>
There is a difference between the two verbs: getVdsCaps and getStats are used
for different usages, in different steps of the host life cycle. If we can
spare the activation of the first based on the output from the second, why
shouldn't we do so ?
--
To view, visit http://gerrit.ovirt.org/25234
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I407d165e1cf13bbd1ba50811eaed4771c3f36f1a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
