Moti Asayag has posted comments on this change. Change subject: engine: Collect stats based on non-operational reason ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25234/2//COMMIT_MSG Commit Message: Line 11: more. Therefore any attempt to activate the host Line 12: by the Auto-Recovery manager will be skipped. Line 13: Even if the network issue will be solved, the host Line 14: will remain non-operational unless activated by Line 15: the user. > what is the difference in activate of user / Auto-Recovery? While activating the host - the nics status isn't being examined. Host activation invokes getVdsCaps - only detects missing networks Host monitoring invokes getStats - detects the nics status We used to have a bug that the auto-recovery would flap host status from up to non-operational. As part of that bug be no longer activate hosts that has a problematic nics. But without invoking getStats, the nics status will not be updated. That's why the logic between the auto-recovery to activate is a bit different. You could claim however that if the getStas reports a problematic nics, no need to activate the host since it will end up as non-operational (meaning only when activating non-operational hosts), but this will require the same fix as this patch suggests. Line 16: Line 17: This patch will allow to examine the cause for the non- Line 18: operational status and continue stats collection to Line 19: assure a network issue was solved and re-attempt to -- To view, visit http://gerrit.ovirt.org/25234 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I407d165e1cf13bbd1ba50811eaed4771c3f36f1a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
