Lior Vernia has posted comments on this change.

Change subject: webadmin: removing menu header from the menu in setup network 
dialog
......................................................................


Patch Set 6: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/24982/6/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/MenuBar.java
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/MenuBar.java:

Line 61:         }
Line 62:     }
Line 63: 
Line 64:     public boolean isEmpty(){
Line 65:         return getItems() == null || getItems().size() == 0;
Don't think items can be null, and ArrayList (as well as List and Collection) 
has an isEmpty() method itself...
Line 66:     }


-- 
To view, visit http://gerrit.ovirt.org/24982
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5634479c91046987591875954b3995fcd25c6d17
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to