Alona Kaplan has posted comments on this change.

Change subject: webadmin: removing menu header from the menu in setup network 
diaplog
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.ovirt.org/#/c/24982/5//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-03-02 09:28:11 +0200
Line 4: Commit:     Alona Kaplan <alkap...@redhat.com>
Line 5: CommitDate: 2014-03-02 10:17:06 +0200
Line 6: 
Line 7: webadmin: removing menu header from the menu in setup network diaplog
> Small typo... Next line as well...
Done
Line 8: 
Line 9: Removing the "menu for" header from the menu in setup network diaplog.
Line 10: 
Line 11: Bug-Url: https://bugzilla.redhat.com/1009774


http://gerrit.ovirt.org/#/c/24982/5/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/MenuBar.java
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/MenuBar.java:

Line 60:         }
Line 61:         }
Line 62:     }
Line 63: 
Line 64:     public int size(){
> Since all we care about is whether it's empty or not (rather than how many 
Done
Line 65:         return getItems().size();
Line 66:     }
Line 67: 


-- 
To view, visit http://gerrit.ovirt.org/24982
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5634479c91046987591875954b3995fcd25c6d17
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to