Oved Ourfali has posted comments on this change. Change subject: engine: Add support for IBM Tivoli Directory Server. ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) Great work you done here! Had a minor indentation comment. Also added Roy to the reviewers, as he might have input on that. .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java Line 176: query = "(&(objectClass=person)(uid=" + userName + "))"; fix the indentation here (unless gerrit is mistakenly showing it unindented, and in that case ignore the comment :-) ). -- To view, visit http://gerrit.ovirt.org/4633 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffe980022787936fc79370104bb7f5c1129f0ce5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
