Oved Ourfali has posted comments on this change. Change subject: engine: Can't add user without system level admin permission ......................................................................
Patch Set 10: Code-Review+1 (2 comments) minor comments. http://gerrit.ovirt.org/#/c/25225/10/frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties File frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties: Line 67: ActionGroup___EDIT_VM_POOL_CONFIGURATION=Edit Properties Line 68: ActionGroup___VM_POOL_BASIC_OPERATIONS=Basic Operations Line 69: ActionGroup___MANIPULATE_USERS=Manipulate Users Line 70: ActionGroup___MANIPULATE_PERMISSIONS=Manipulate Permissions Line 71: ActionGroup___ADD_USERS_AND_GROUPS_FROM_DIRECTORY=Add users from directory while adding a permissions add users and groups, not just users. Also, I'd write either "directory users" or "from a directory", or just users. Line 72: ActionGroup___LOGIN=Login Permissions Line 73: ActionGroup___TAG_MANAGEMENT=Tag management Permissions Line 74: ActionGroup___BOOKMARK_MANAGEMENT=Bookmark management Permissions Line 75: ActionGroup___EVENT_NOTIFICATION_MANAGEMENT=Event notification management Permissions http://gerrit.ovirt.org/#/c/25225/10/packaging/dbscripts/upgrade/03_05_0070_add_missing_manipulate_users_permissions.sql File packaging/dbscripts/upgrade/03_05_0070_add_missing_manipulate_users_permissions.sql: Line 6: v_MANIPULATE_PERMISSIONS INTEGER; Line 7: BEGIN Line 8: v_ADD_USERS_AND_GROUPS_FROM_DIRECTORY = 503; Line 9: v_MANIPULATE_PERMISSIONS = 502; Line 10: INSERT INTO ROLES_GROUPS(role_id,action_group_id) Why the extra indentation here? Line 11: SELECT rg.role_id, v_ADD_USERS_AND_GROUPS_FROM_DIRECTORY Line 12: FROM ROLES_GROUPS rg Line 13: WHERE Line 14: action_group_id = v_MANIPULATE_PERMISSIONS -- To view, visit http://gerrit.ovirt.org/25225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I308f9cc5edb53b9633d768fd3d382dc9cf62031c Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
