Ravi Nori has posted comments on this change.

Change subject: engine: Can't add user without system level admin permission
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.ovirt.org/#/c/25225/9/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendPermitResource.java
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendPermitResource.java:

Line 32: 
Line 33:     @Override
Line 34:     protected Permit addParents(Permit permit) {
Line 35:         if (permit == null) {
Line 36:             System.out.println("permit is null");
> why the system.out.println?
Sorry wrong patch, will fix these
Line 37:         }
Line 38:         if (parent == null) {
Line 39:             System.out.println("parent is null");
Line 40:         }


-- 
To view, visit http://gerrit.ovirt.org/25225
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I308f9cc5edb53b9633d768fd3d382dc9cf62031c
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to