Liron Ar has posted comments on this change. Change subject: core: fail deletion of template disk with derived disks ......................................................................
Patch Set 3: Verified+1 @Maor - "What if we will remove a copy of the disk in the template. do we handle it now? don't we need to use the same message?" I handled it, take a look in RemoveDiskCommand in this patch. "Regarding my last comment we are already doing this validation in the RemovevmTemplate (related to VMT_CANNOT_REMOVE_DETECTED_DERIVED_VM) am I missing something?" If there are floating disks derived from the template (not vms, disks) - the vm check won't work. -- To view, visit http://gerrit.ovirt.org/22428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifca48993f40f3c5f7b603f33add7049e78e6c4e9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
