Maor Lipchuk has posted comments on this change. Change subject: core: fail deletion of template disk with derived disks ......................................................................
Patch Set 3: (1 comment) Regarding my last comment we are already doing this validation in the RemovevmTemplate (related to VMT_CANNOT_REMOVE_DETECTED_DERIVED_VM) am I missing something? http://gerrit.ovirt.org/#/c/22428/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java: Line 170: Line 171: if (!disksInfo.isEmpty()) { Line 172: return new ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_DETECTED_DERIVED_DISKS, Line 173: String.format("$disksInfo %s", Line 174: String.format(StringUtils.join(disksInfo, "%n")))); you should probably also add the vm names here, since the disks' alias are not unique but vm names are. Line 175: } Line 176: Line 177: return ValidationResult.VALID; Line 178: } -- To view, visit http://gerrit.ovirt.org/22428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifca48993f40f3c5f7b603f33add7049e78e6c4e9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
