Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Allow answer-file-only mode ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25290/2/packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py File packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py: Line 114: ) Line 115: ) Line 116: Line 117: if self.environment[osetupcons.CoreEnv.ANSWER_FILE_ONLY]: Line 118: raise context.Abort(_('Running in answer-file-only mode, exiting')) why not move answer file to cleanup instead of closeup, and allow people to <Ctrl>C whenever they want or just type cancel at confirmation? Line 119: Line 120: -- To view, visit http://gerrit.ovirt.org/25290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b6af75001eb3192e6839e57dbb7446344ff29f4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <simone.tirabos...@gmail.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
