Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Allow answer-file-only mode ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25290/1/packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py File packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py: Line 116: if self.environment[osetupcons.CoreEnv.ANSWER_FILE_ONLY]: Line 117: self.logger.info( Line 118: _('Running in answer-file-only mode, exiting') Line 119: ) Line 120: sys.exit(0) > shouldn't this be something like [ INFO ] Generating answer file '/var/lib/ovirt-engine/setup/answers/20140304092748-setup.conf' [ INFO ] Generating answer file 'answer1' [WARNING] Aborted [ INFO ] Stage: Clean up Log file is located at /var/log/ovirt-engine/setup/ovirt-engine-setup-20140304092643.log [ INFO ] Stage: Pre-termination [ INFO ] Stage: Termination [ ERROR ] Execution of setup failed Is that what we want? It also does not show the message, not sure why. Line 121: Line 122: -- To view, visit http://gerrit.ovirt.org/25290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b6af75001eb3192e6839e57dbb7446344ff29f4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <simone.tirabos...@gmail.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches