Liran Zelkha has posted comments on this change.

Change subject: core: Remove error message when reports.xml doesn't exist
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.ovirt.org/#/c/25324/2//COMMIT_MSG
Commit Message:

Line 12: exist
> How do we handle a missing reports file when the reports module is installe
I think this config value should change as part of the reports installation. 
What do you think?


http://gerrit.ovirt.org/#/c/25324/2/packaging/dbscripts/upgrade/03_05_0070_not_required_files.sql
File packaging/dbscripts/upgrade/03_05_0070_not_required_files.sql:

Line 1: select 
fn_db_add_config_value('NotRequiredFiles','reports.xml','general');
> Sorry for the noise (my fault) , those configs should be at the dbscripts/u
Done


-- 
To view, visit http://gerrit.ovirt.org/25324
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf6b075eb4754c5bb4153da8c6032a01bf801516
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to