Eli Mesika has posted comments on this change. Change subject: core: Remove error message when reports.xml doesn't exist ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/25324/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/ServletUtils.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/ServletUtils.java: Line 125: isWhiteListFiles more occurate to name as isWhiteListFile Line 134: return maybe instead of 3 returns boolean ret=false; if (file != null && Config.<String> getValue(ConfigValues.NotRequiredFiles).contains(file.getName())) { ret = true; } return ret; http://gerrit.ovirt.org/#/c/25324/1/packaging/dbscripts/upgrade/03_04_0650_not_required_files.sql File packaging/dbscripts/upgrade/03_04_0650_not_required_files.sql: Line 1: fn_db_add_config_value Keep in mind that this is master stuff , should be prefixed with 03_05 (in stable 3.4 its 03_04) -- To view, visit http://gerrit.ovirt.org/25324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf6b075eb4754c5bb4153da8c6032a01bf801516 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
