Martin Peřina has posted comments on this change. Change subject: tools: Match transport names with EventNotificationMethod ......................................................................
Patch Set 3: So we have 3 options: 1) This patch, thanks to which we have "smtp"/"snmp" in db and config 2) Or have "SMTP"/"SNMP" in db and convert to "smtp"/"snmp" in EventsManager.getAuditLogEventSubcribers. But I don't like doing such conversion outside EventNotificationMethod scope. 3) Or rename EventNotificationMethod enum values to lower case, which violates Java Coding Conventions -- To view, visit http://gerrit.ovirt.org/25204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie93d2d371a6f29a33e32a776e74ada5f221cbb4e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
