mooli tayer has posted comments on this change. Change subject: tools: Match transport names with EventNotificationMethod ......................................................................
Patch Set 3: Two issues here: >> Because Transport.getName() return lowercase variants. I'm not sure why Transport.getName() returns string and not EventNotificationMethod. what I would do is have a simple enum with only values and use those EVERYWHERE(db, code, Transport interface). > So IMO it's more clear to hide database/external string representation into > EventNotificationMethod than directly matching > EventNotificationMethod.name().toLowerCase() in the code outside the scope of > EventNotificationMethod class. I agree, don't do it in the code, only use one value. Our external representation is not independent now either: if we change a name its lower case changes as well. I think its ok that if we change a value in EventNotificaitionMethod we know we need to create an upgrade script... ? -- To view, visit http://gerrit.ovirt.org/25204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie93d2d371a6f29a33e32a776e74ada5f221cbb4e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
