Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: database: extend check empty ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/25272/3/packaging/dbscripts/dbfunc-common.sh File packaging/dbscripts/dbfunc-common.sh: Line 55: if [ "$(dbfunc_psql_statement_parsable " Line 56: select count(*) as count Line 57: from pg_catalog.pg_tables Line 58: where table_name = 'schema_version' Line 59: and schemaname = 'public' you are going to kill me! but... select xxx from yyyy where table_name = 'schema_version' and schemaname = 'public' Line 60: ")" -eq 0 ]; then Line 61: echo "Creating fresh schema" Line 62: _dbfunc_common_schema_create Line 63: fi -- To view, visit http://gerrit.ovirt.org/25272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7de630ba6130aa349c15c1101cf2b041614fa5eb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
