Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: database: extend check empty ......................................................................
Patch Set 2: > not sure how to verify that, as I do not see calls to > dbfunc_common_schema_apply . Eli? the engine-setup calls the schema.sh which uses it. if setup on clean database and setup for upgrade works then you are good. > Also, your dbscripts cleanup was not backported to 3.4 (and I understand > never will), I don't find similar code in 3.4, so I am leaving > http://gerrit.ovirt.org/25273 without this. Correct, you do not need to backport this hank into 3.4. -- To view, visit http://gerrit.ovirt.org/25272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7de630ba6130aa349c15c1101cf2b041614fa5eb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
