Yair Zaslavsky has posted comments on this change. Change subject: [WIP] core: can't add user without system level admin permission ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/25225/5//COMMIT_MSG Commit Message: Line 11: 1. Introducing a new permission of adding non existing users - this is required, as the other options are: Line 12: a. Using the existing "manipulate users" permission - this will cause a regression, allowing roles to add users directly without the need to use the add permissions dialogs. Line 13: b. Removing the permission check for non existing users/groups - this will break https://bugzilla.redhat.com/923100 Line 14: Line 15: 2. The new permission is added to all the roles that have manipulate permissions manipulation - > s/that have manipulate permissions manipulation/that have manipulate_permis Done Line 16: this is done in order to fix the above regression. Line 17: Line 18: Change-Id: I308f9cc5edb53b9633d768fd3d382dc9cf62031c Line 19: Bug-Url: https://bugzilla.redhat.com/1070651 -- To view, visit http://gerrit.ovirt.org/25225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I308f9cc5edb53b9633d768fd3d382dc9cf62031c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
