Oved Ourfali has posted comments on this change. Change subject: [WIP] core: can't add user without system level admin permission ......................................................................
Patch Set 4: (2 comments) See two comments. Also, what about groups? http://gerrit.ovirt.org/#/c/25225/4/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java: You can use: "Add users from directory while adding a permissions" Line 1: package org.ovirt.engine.ui.uicompat; Line 2: Line 3: Line 4: import org.ovirt.engine.core.common.businessentities.VmPool; http://gerrit.ovirt.org/#/c/25225/4/packaging/dbscripts/upgrade/03_05_0070_add_missing_manipulate_users_permissions.sql File packaging/dbscripts/upgrade/03_05_0070_add_missing_manipulate_users_permissions.sql: What about custom roles? Shouldn't you just add it to roles that had it? Line 1: Create or replace FUNCTION _temp_add_missing_manipulate_users_permissions() Line 2: RETURNS VOID Line 3: AS $procedure$ Line 4: DECLARE -- To view, visit http://gerrit.ovirt.org/25225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I308f9cc5edb53b9633d768fd3d382dc9cf62031c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
