Moti Asayag has posted comments on this change.

Change subject: engine: add support for network port mirroring
......................................................................


Patch Set 8: (1 inline comment)

....................................................
File backend/manager/dbscripts/create_functions.sql
Line 417: CREATE OR REPLACE FUNCTION public.fn_get_entity_name(v_entity_id IN 
uuid, v_object_type IN int4) RETURNS text AS
please add also a test same as exists for each entity in
DbFacadeDAOTest.testGetEntityNameByIdAndTypeForXXX()

--
To view, visit http://gerrit.ovirt.org/3726
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I901fb97580cf2cb14b3f10f92af4d942d33250b5
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to