Moti Asayag has posted comments on this change. Change subject: engine: add support for network port mirroring ......................................................................
Patch Set 8: I would prefer that you didn't submit this (3 inline comments) .................................................... File backend/manager/dbscripts/create_functions.sql Line 170: v_storage_pool_id uuid; the field ds_id uuid; acts the same as v_storage_pool_id, however the name you set for this field is better than the current. a later patch to replace the ds_id with v_storage_pool_id will be more than welcome. Line 294: vm_interface.id, network_view.storage_domain_id this will fail - no field named storage_domain_id on network_view. it should be modified to network_view.storage_pool_id. .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java Line 471: struct.add(VdsProperties.portMirroring, new Boolean(vmInterface.isPortMirroring()).toString()); Since this property typed boolean, you can use: Boolean.toString(vmInterface.isPortMirroring()) -- To view, visit http://gerrit.ovirt.org/3726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I901fb97580cf2cb14b3f10f92af4d942d33250b5 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
