Kiril Nesenko has posted comments on this change. Change subject: Add generic code to check repoclosure ......................................................................
Patch Set 3: (5 comments) http://gerrit.ovirt.org/#/c/24802/3/jobs/packaging/repo_closure_check.sh File jobs/packaging/repo_closure_check.sh: Line 3: LAYOUT > Maybe specify a default layout not sure if we need a default layout Line 17: __EOF__ Line 18: } Line 19: Line 20: get_opts() { Line 21: while [-n "${1}" ]; do > using simple '[' you must leave a space after the '[' or it will fail. :) Line 22: v="${opt#*=}" Line 23: shift Line 24: case "${opt}" in Line 25: --distribution=*) Line 63: if [ "${EL6}" != "true" ]; then Line 64: echo "SKIPPING RUN: EL6 not checked in the configuration" Line 65: exit 0 Line 66: fi Line 67: custom_url="${BASE_URL}/${REPO_NAME}/rpm/${el6}" > Odd indenting here Done Line 68: repoclosure \ Line 69: -t \ Line 70: --repofrompath=check-custom,"${custom_url}" \ Line 71: --repofrompath=check-base,http://centos.mirror.constant.com/6/os/x86_64/ \ Line 78: repofrompath > Check the job again, jpackage repos are also needed now for centos Done Line 78: --repofrompath=check-glusterfs-epel-noarch,http://download.gluster.org/pub/gluster/glusterfs/LATEST/EPEL.repo/epel-6.4/noarch \ Line 79: -l check-updates \ Line 80: -l check-extras \ Line 81: -l check-epel \ Line 82: -l check-epel-testing \ > By adding testing here, aren't we requiring users to enable epel-testing? have no idea ... Sandro,David ? Line 83: -l check-glusterfs-epel \ Line 84: -l check-glusterfs-noarch-epel\ Line 85: -l check-base \ Line 86: -l check-base-i386 \ -- To view, visit http://gerrit.ovirt.org/24802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I762abf97c9020301a388f7d83c7d1e41bdf1f062 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
