Omer Frenkel has posted comments on this change. Change subject: WIP: engine: fetch exit reason from VDSM ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/23946/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java: Line 280: public void InternalSetVmStatus(VM vm, final VMStatus status, final VmExitStatus exitStaus, final String exitMessage, final VmExitReason exitReason) { Line 281: vm.setStatus(status); Line 282: vm.setExitStatus(exitStaus); Line 283: vm.setExitMessage(exitMessage); Line 284: vm.setExitReason(exitReason); > Sorry, I almost forgot a key factor. I've also added (after suggestion on t you are right, there is a backward compatibility issue here that i didnt think of. i guess we do need another field as you did, but we need it to replace the existing one (make it deprecated) in order to make this duplication go away in the future. for that we would need to save for each new reason, if its error or not, so we could use it in the code instead of the old field. Line 285: boolean isVmNotRunning = status.isNotRunning(); Line 286: Line 287: if (isVmNotRunning || status == VMStatus.Unknown) { Line 288: resetVmAttributes(vm); -- To view, visit http://gerrit.ovirt.org/23946 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib36f06f3ba63a743d624e417fe2c96b84dda60be Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
