Francesco Romani has posted comments on this change. Change subject: WIP: engine: fetch exit reason from VDSM ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/23946/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java: Line 280: public void InternalSetVmStatus(VM vm, final VMStatus status, final VmExitStatus exitStaus, final String exitMessage, final VmExitReason exitReason) { Line 281: vm.setStatus(status); Line 282: vm.setExitStatus(exitStaus); Line 283: vm.setExitMessage(exitMessage); Line 284: vm.setExitReason(exitReason); > if you are using the existing field name (exitCode) and just add more value Sorry, I almost forgot a key factor. I've also added (after suggestion on the review of the VDSM patchset) detailed reason code for succesfull shutdown, meaning the VM was terminated correctly as expected e.g. after a succesful migration. Unfortunately this is no longer compatible with the domain of ExitCode, because on ExitCode only 'zero' is 'success'. Even if we adopt an encoding like values < 0 errors, 0 genric success, >0 specific success code we are no longer backward compatible. So either we drop the detailed success values or we retain a distinct additional exit reason code. (WIKI page is being updated) Line 285: boolean isVmNotRunning = status.isNotRunning(); Line 286: Line 287: if (isVmNotRunning || status == VMStatus.Unknown) { Line 288: resetVmAttributes(vm); -- To view, visit http://gerrit.ovirt.org/23946 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib36f06f3ba63a743d624e417fe2c96b84dda60be Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
