Alon Bar-Lev has posted comments on this change. Change subject: 10. [WIP] core: Introducing AuthenticationProfileRepository ......................................................................
Patch Set 23: (3 comments) http://gerrit.ovirt.org/#/c/24366/23/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/Authenticator.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/Authenticator.java: Line 7: Line 8: /** Line 9: * A authenticator is an object used to verify an identity. Line 10: */ Line 11: public abstract class Authenticator implements Extension { hmm... shouldn't this be when you introduce the context? at the Extension interface introduction patch? Line 12: Line 13: /** Line 14: * Returns the name of the profile the authenticator is associated with Line 15: * @return profile name Line 31: @Override Line 32: public void init() { Line 33: name = (String) context.get(ExtensionProperties.NAME); Line 34: Properties config = (Properties) context.get(ExtensionProperties.CONFIGURATION); Line 35: if (config != null) { how can it be null? Line 36: profileName = config.getProperty("ovirt.engine.aaa.authn.profile.name"); Line 37: } Line 38: } Line 39: Line 45: protected Authenticator() { Line 46: } Line 47: Line 48: protected String profileName; Line 49: protected String name; why do you need to keep these around, when you can delegate the getters into the context? Line 50: protected Map<Extension.ExtensionProperties, Object> context; Line 51: -- To view, visit http://gerrit.ovirt.org/24366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If375fccea98544c64d9ec41cc9dbcb855bf02fb7 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
