Alon Bar-Lev has posted comments on this change. Change subject: 10. [WIP] core: Introducing AuthenticationProfileRepository ......................................................................
Patch Set 19: (3 comments) http://gerrit.ovirt.org/#/c/24366/19/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java: Line 69: for (ExtensionEntry authnExtension : ConfigurationLoader.getInstance().getExtensionsByService(AUTHN_SERVICE)) { Line 70: registerProfile( Line 71: new AuthenticationProfile( Line 72: (Authenticator) authnExtension.getExtension(), Line 73: (Directory) ConfigurationLoader.getInstance().getExtensionByName( this should be indented if so the god of eclipse permits. Line 74: authnExtension.getConfig().getString(AUTHN_AUTHZ_PLUGIN) Line 75: ).getExtension() Line 76: ) Line 77: ); http://gerrit.ovirt.org/#/c/24366/19/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/DirectoryUtils.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/DirectoryUtils.java: Line 32: Line 33: public static Directory getDirectoryByName(String directoryName) { Line 34: for (AuthenticationProfile profile : AuthenticationProfileRepository.getInstance().getProfiles()) { Line 35: if (profile.getDirectory().getName().equals(directoryName)) { Line 36: return null; ha? Line 37: } Line 38: } Line 39: return null; Line 40: http://gerrit.ovirt.org/#/c/24366/19/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java: Line 37: } Line 38: Line 39: private DbUserCacheManager() { Line 40: for (AuthenticationProfile profile : AuthenticationProfileRepository.getInstance().getProfiles()) { Line 41: directoriesMap.put(profile.getDirectory().getName(), profile.getDirectory()); why can't we use the authenticationprofilerepos? why do we need to duplicate it once more? Line 42: } Line 43: Line 44: } Line 45: -- To view, visit http://gerrit.ovirt.org/24366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If375fccea98544c64d9ec41cc9dbcb855bf02fb7 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
