Yair Zaslavsky has posted comments on this change. Change subject: 8. [WIP] core: Introducing the extension interface ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/24811/3/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/Authenticator.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/Authenticator.java: Line 31: Line 32: public Properties getConfigurationProperties() { Line 33: return properties; Line 34: } Line 35: > where is the context usage? this class should not be in this patch, sorry. Line 36: protected Authenticator(String profileName) { Line 37: this.profileName = profileName; Line 38: } Line 39: -- To view, visit http://gerrit.ovirt.org/24811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8f583d635c059972a2a536d3c49a58cfcf3234b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
