Alon Bar-Lev has posted comments on this change. Change subject: 8. [WIP] core: Introducing the extension interface ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/24811/3/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/Authenticator.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/Authenticator.java: Line 31: Line 32: public Properties getConfigurationProperties() { Line 33: return properties; Line 34: } Line 35: where is the context usage? Line 36: protected Authenticator(String profileName) { Line 37: this.profileName = profileName; Line 38: } Line 39: http://gerrit.ovirt.org/#/c/24811/3/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/Directory.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/Directory.java: Line 10: /** Line 11: * A directory is an object that manages a collection of users and groups, usually stored in an external system like an Line 12: * LDAP database. Line 13: */ Line 14: public abstract class Directory implements Extension, Serializable { haven't we agreed not to have this serializable? or to have both? Line 15: /** Line 16: * Line 17: */ Line 18: private static final long serialVersionUID = -8724317446083142917L; Line 32: } Line 33: Line 34: public void setConfigurationProperties(Properties configurationProperties) { Line 35: this.configruationProperties = configurationProperties; Line 36: } where is the use of the context? Line 37: Line 38: /** Line 39: * Retrieves a user from the directory given its name. The name is expected to be unique. Line 40: * -- To view, visit http://gerrit.ovirt.org/24811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8f583d635c059972a2a536d3c49a58cfcf3234b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
