Yaniv Dary has posted comments on this change. Change subject: reports: edited input controls queries ......................................................................
Patch Set 1: (13 comments) http://gerrit.ovirt.org/#/c/24585/1/packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/P_Period.xml File packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/P_Period.xml: Line 20: <label>period</label> Line 21: <creationDate>2014-02-17T11:32:29.182+02:00</creationDate> Line 22: <updateDate>2014-02-17T11:32:29.182+02:00</updateDate> Line 23: <language>sql</language> Line 24: <queryString>--Used for Input control "P_Period" get period in local language and the corresponding value "Used for Input control "P_Period"" - This is self explanatory since this is that input control resource file and not needed. correct typos - "Gets period in localized language and the corresponding period value in numbers" Line 25: Line 26: SELECT DISTINCT Line 27: enum_translator_default.enum_key as period, Line 28: coalesce( http://gerrit.ovirt.org/#/c/24585/1/packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/P_Start_Date.xml File packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/P_Start_Date.xml: Line 20: <label>startDate</label> Line 21: <creationDate>2014-02-17T11:57:39.099+02:00</creationDate> Line 22: <updateDate>2014-02-17T11:57:39.099+02:00</updateDate> Line 23: <language>sql</language> Line 24: <queryString>--For Input control "P_Start_Date" . same comment. not needed. Line 25: --If period is "Daily" then the select list will present a days list for the past 2 months. Line 26: --If period is not "Daily" then the select list will present a "From"-"To" dates list, since the beginning of month of the firstSync. Line 27: Line 28: SELECT DISTINCT Line 21: <creationDate>2014-02-17T11:57:39.099+02:00</creationDate> Line 22: <updateDate>2014-02-17T11:57:39.099+02:00</updateDate> Line 23: <language>sql</language> Line 24: <queryString>--For Input control "P_Start_Date" . Line 25: --If period is "Daily" then the select list will present a days list for the past 2 months. list select* a dates list* for the last* Line 26: --If period is not "Daily" then the select list will present a "From"-"To" dates list, since the beginning of month of the firstSync. Line 27: Line 28: SELECT DISTINCT Line 29: CASE Line 22: <updateDate>2014-02-17T11:57:39.099+02:00</updateDate> Line 23: <language>sql</language> Line 24: <queryString>--For Input control "P_Start_Date" . Line 25: --If period is "Daily" then the select list will present a days list for the past 2 months. Line 26: --If period is not "Daily" then the select list will present a "From"-"To" dates list, since the beginning of month of the firstSync. Please explain what is firstSync. Line 27: Line 28: SELECT DISTINCT Line 29: CASE Line 30: WHEN $P{P_Period} = 0 http://gerrit.ovirt.org/#/c/24585/1/packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/is_deleted.xml File packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/is_deleted.xml: Line 20: <label>is_deleted</label> Line 21: <creationDate>2014-02-17T10:04:49.427+02:00</creationDate> Line 22: <updateDate>2014-02-17T10:04:49.427+02:00</updateDate> Line 23: <language>sql</language> Line 24: <queryString>-- Used for Input control "P_deleted" display "Yes" or "No" same Line 25: -- in the local language of the user and pass the value to the report query. Line 26: Line 27: SELECT DISTINCT Line 28: coalesce( Line 21: <creationDate>2014-02-17T10:04:49.427+02:00</creationDate> Line 22: <updateDate>2014-02-17T10:04:49.427+02:00</updateDate> Line 23: <language>sql</language> Line 24: <queryString>-- Used for Input control "P_deleted" display "Yes" or "No" Line 25: -- in the local language of the user and pass the value to the report query. localized of the session* and passes* Line 26: Line 27: SELECT DISTINCT Line 28: coalesce( Line 29: enum_translator_localized.value_localized, Line 29: enum_translator_localized.value_localized, Line 30: enum_translator_default.value Line 31: ) Line 32: as display, Line 33: 'AND delete_date IS NULL' as value explain why this is used the value. Line 34: FROM enum_translator as enum_translator_default Line 35: LEFT OUTER JOIN Line 36: ( Line 37: SELECT http://gerrit.ovirt.org/#/c/24585/1/packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/cluster_ic/all_cluster_with_vms/P_Cluster_ID.xml File packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/cluster_ic/all_cluster_with_vms/P_Cluster_ID.xml: Line 20: <label>Cluster</label> Line 21: <creationDate>2014-02-17T13:04:56.608+02:00</creationDate> Line 22: <updateDate>2014-02-17T13:04:56.608+02:00</updateDate> Line 23: <language>sql</language> Line 24: <queryString>-- Used for Cluster_ID parameter. same Line 25: --This will display in the select list the clusters list. Line 26: --The list can include deleted clusters, according to the value of the "is_deleted" parameter. Line 27: --The deleted cluster names will be concatenated along with their remove date. Line 28: Line 21: <creationDate>2014-02-17T13:04:56.608+02:00</creationDate> Line 22: <updateDate>2014-02-17T13:04:56.608+02:00</updateDate> Line 23: <language>sql</language> Line 24: <queryString>-- Used for Cluster_ID parameter. Line 25: --This will display in the select list the clusters list. this will display only the clusters that have vms. Line 26: --The list can include deleted clusters, according to the value of the "is_deleted" parameter. Line 27: --The deleted cluster names will be concatenated along with their remove date. Line 28: Line 29: Line 138: $P!{is_deleted} Line 139: Line 140: UNION ALL Line 141: Line 142: -- This sub-query is for displaying the "All" option in the select list in local language. localized* Line 143: Line 144: SELECT DISTINCT Line 145: '11111111-1111-1111-1111-111111111111', Line 146: cast( NULL as timestamp ), http://gerrit.ovirt.org/#/c/24585/1/packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/datacenter_ic/all_dcs_with_vms/P_DataCenter_ID.xml File packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/datacenter_ic/all_dcs_with_vms/P_DataCenter_ID.xml: Line 20: <label>Data_Centers</label> Line 21: <creationDate>2014-02-17T13:05:11.696+02:00</creationDate> Line 22: <updateDate>2014-02-17T13:05:11.696+02:00</updateDate> Line 23: <language>sql</language> Line 24: <queryString>--Used for DataCenter_ID parameter. same Line 25: --This will display in the select list the Data Center list. Line 26: --The list can include deleted Data Centers, according to the value of the "is_deleted" parameter. Line 27: --The deleted Data Centers names will be concatenated along with their remove date. Line 28: Line 21: <creationDate>2014-02-17T13:05:11.696+02:00</creationDate> Line 22: <updateDate>2014-02-17T13:05:11.696+02:00</updateDate> Line 23: <language>sql</language> Line 24: <queryString>--Used for DataCenter_ID parameter. Line 25: --This will display in the select list the Data Center list. same fix as cluster. Line 26: --The list can include deleted Data Centers, according to the value of the "is_deleted" parameter. Line 27: --The deleted Data Centers names will be concatenated along with their remove date. Line 28: Line 29: SELECT DISTINCT http://gerrit.ovirt.org/#/c/24585/1/packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/vm_ic/P_VM_Type.xml File packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/vm_ic/P_VM_Type.xml: Line 22: <creationDate>2014-02-17T13:10:41.540+02:00</creationDate> Line 23: <updateDate>2014-02-17T13:10:41.540+02:00</updateDate> Line 24: <language>sql</language> Line 25: <queryString>-- Used for VM_type parameter. Line 26: --This will display in the select list the VM types list in local language. localized* Line 27: Line 28: SELECT DISTINCT Line 29: coalesce ( Line 30: enum_translator_localized.value_localized, -- To view, visit http://gerrit.ovirt.org/24585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1338ac49d4f7cfcd7c731e42235fad0a91cbf6ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
