Yaniv Dary has posted comments on this change.

Change subject: reports: edited input controls queries
......................................................................


Patch Set 4:

(6 comments)

http://gerrit.ovirt.org/#/c/24676/4/packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/P_Start_Date.xml
File 
packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/P_Start_Date.xml:

Line 21:             <creationDate>2014-02-17T11:57:39.099+02:00</creationDate>
Line 22:             <updateDate>2014-02-17T11:57:39.099+02:00</updateDate>
Line 23:             <language>sql</language>
Line 24:             <queryString>--If period is "Daily" then the select list 
will display a dates list for the last 2 months.
Line 25: --If period is not "Daily" then the select list will present a 
"From"-"To" dates list, 
trailing white space.
Line 26: --since the beginning of the month of the firstSync.
Line 27: --firstSync is the date of the first time data from the engine db was 
updated to the engine_history db.
Line 28: 
Line 29: SELECT DISTINCT


http://gerrit.ovirt.org/#/c/24676/4/packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/is_deleted.xml
File 
packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/is_deleted.xml:

Line 20:             <label>is_deleted</label>
Line 21:             <creationDate>2014-02-17T10:04:49.427+02:00</creationDate>
Line 22:             <updateDate>2014-02-17T10:04:49.427+02:00</updateDate>
Line 23:             <language>sql</language>
Line 24:             <queryString>-- The select list will display "Yes" or 
"No", 
trailing whitespace
Line 25: -- if the user chose to include deleted entities or not 
correspondingly.
Line 26: -- localized of the session and pass the value to the report query.
Line 27: 
Line 28: SELECT DISTINCT


Line 22:             <updateDate>2014-02-17T10:04:49.427+02:00</updateDate>
Line 23:             <language>sql</language>
Line 24:             <queryString>-- The select list will display "Yes" or 
"No", 
Line 25: -- if the user chose to include deleted entities or not 
correspondingly.
Line 26: -- localized of the session and pass the value to the report query.
The value is localized according to the session and passed to the report query.*
Line 27: 
Line 28: SELECT DISTINCT
Line 29:     coalesce(
Line 30:         enum_translator_localized.value_localized,


http://gerrit.ovirt.org/#/c/24676/4/packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/cluster_ic/all_cluster_with_vms/P_Cluster_ID.xml
File 
packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/cluster_ic/all_cluster_with_vms/P_Cluster_ID.xml:

Line 20:             <label>Cluster</label>
Line 21:             <creationDate>2014-02-17T13:04:56.608+02:00</creationDate>
Line 22:             <updateDate>2014-02-17T13:04:56.608+02:00</updateDate>
Line 23:             <language>sql</language>
Line 24:             <queryString>--This will display in the select list only 
the clusters that have vms.
only cluster*
Line 25: --The list can include deleted clusters, according to the value of the 
"is_deleted" parameter.
Line 26: --The deleted cluster names will be concatenated along with their 
remove date.
Line 27: 
Line 28: 


http://gerrit.ovirt.org/#/c/24676/4/packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/vm_ic/P_VM_Type.xml
File 
packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/vm_ic/P_VM_Type.xml:

Line 21:             <label>VM_type</label>
Line 22:             <creationDate>2014-02-17T13:10:41.540+02:00</creationDate>
Line 23:             <updateDate>2014-02-17T13:10:41.540+02:00</updateDate>
Line 24:             <language>sql</language>
Line 25:             <queryString>--This will display in the select list the VM 
types list localized.
of localized VM types*
Line 26: 
Line 27: SELECT DISTINCT
Line 28:     coalesce (
Line 29:             enum_translator_localized.value_localized,


Line 95:         $P!{is_deleted}
Line 96: 
Line 97: UNION ALL
Line 98: 
Line 99: -- This sub-query is for displaying the "All" option in the select 
list localized.
list. The value is localized.*
Line 100: 
Line 101: SELECT DISTINCT
Line 102:     coalesce(
Line 103:         enum_translator_localized.value_localized,


-- 
To view, visit http://gerrit.ovirt.org/24676
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56bd7583fd20c1ead3c760a922a37b5c1ac87da5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <[email protected]>
Gerrit-Reviewer: Shirly Radco <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to