Arik Hadas has posted comments on this change. Change subject: core: refactor SchedulingManager#schedule ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24372/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java: Line 314: return vdsList.get(0).getId(); Line 315: } Line 316: Line 317: if (shouldWeighClusterHosts(cluster, vdsList)) { Line 318: return runFunctions(policy.getFunctions(), vdsList, vm, parameters); > the functionality changed a bit... if runFunctions returns null we shouldn' you're right, I missed it somehow. Line 319: } Line 320: Line 321: if (!vdsList.isEmpty()) { Line 322: return vdsList.get(0).getId(); -- To view, visit http://gerrit.ovirt.org/24372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57b8e4751b4da329658f4b8e1ae2366b1147a137 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
