Martin Sivák has posted comments on this change. Change subject: core: refactor SchedulingManager#schedule ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24372/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java: Line 291: Line 292: private Guid selectBestHost(VDSGroup cluster, Line 293: VM vm, Line 294: Guid destHostId, Line 295: List<VDS> vdsList, Please add comments explaining at least the following arguments for future reference: destHostId - used for RunAt preselection, overrides the ordering in vdsList vdsList - presorted list of hosts (better hosts first) that are available Line 296: ClusterPolicy policy, Line 297: Map<String, String> parameters) { Line 298: // in case a default destination host was specified, and Line 299: // it passed filters return it -- To view, visit http://gerrit.ovirt.org/24372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57b8e4751b4da329658f4b8e1ae2366b1147a137 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
