Juan Hernandez has posted comments on this change. Change subject: webadmin: Fix Java 7 compilation issues ......................................................................
Patch Set 2: Fixed the issue that Vojtech detected in patch set 1. I think there is some confussion in the code about how the "EntityModelTextColumn" should be used. There are several places where it is used as "EntityModelTextColumn<EntityModel>", which I think is wrong. I changed that to "EntityModelTextColumn<WhateverEntity>" where the "getText" method can be used and to "EntityModelTextColumn<Object>" where the "getValue" method is still needed. -- To view, visit http://gerrit.ovirt.org/4315 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f1b74f3b84019b8ba28a2cefaef42db25f39f89 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
