Alon Bar-Lev has posted comments on this change. Change subject: tools: notifier: simple first match include/exclude. ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/24018/12/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java: Line 139: @Override Line 140: public void dispatchEvent(Event event, String address) { Line 141: // throw an exception if not AuditLogEvent Line 142: AuditLogEvent auditLogEvent; Line 143: auditLogEvent = (AuditLogEvent) event; > we can drop the Event in favour of AuditLogEvent for simplicity. Done Line 144: Line 145: if (StringUtils.isEmpty(address)) { Line 146: log.error("Address is empty, cannot distribute message." + event.getName()); Line 147: return; -- To view, visit http://gerrit.ovirt.org/24018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0b94ee8665ff8030b36b463207e50beea44b47d Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
