Alon Bar-Lev has posted comments on this change. Change subject: tools: notifier: simple first match include/exclude. ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/24018/12/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java: Line 111: } Line 112: Line 113: String emailUser = props.getProperty(MAIL_USER, true); Line 114: String emailPassword = props.getProperty(MAIL_PASSWORD, true); Line 115: if (StringUtils.isEmpty(emailUser) && StringUtils.isNotEmpty(emailPassword)) { this is a change, the previous validation was incorrect, this is also incorrect... but less. smtp supports anonymous for ssl... smtp supports user without password. Line 116: throw new IllegalArgumentException( Line 117: String.format( Line 118: "'%s' must be set when password is set", Line 119: MAIL_USER)); -- To view, visit http://gerrit.ovirt.org/24018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0b94ee8665ff8030b36b463207e50beea44b47d Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
