Federico Simoncelli has posted comments on this change. Change subject: core: prevent maintenance when domain is still in use ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/22045/11/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java: Line 319: // domain not attached to pool anymore Line 320: DbFacade.getInstance() Line 321: .getStoragePoolIsoMapDao() Line 322: .remove(new StoragePoolIsoMapId(domainInDb.getId(), Line 323: _storagePoolId)); > few concerns - 1. activated hosts will receive a connectStoragePool with the domain already in maintenance (as we already marked it as PreparingForMaintenance) We don't need to maintain another timer (as we already have this one), to address 2 and 3 we can just use the same event queue. Line 324: } Line 325: if (domainInDb.getStatus() == StorageDomainStatus.PreparingForMaintenance) { Line 326: if (activeVdsInPool == null) { Line 327: activeVdsInPool = getVdsConnectedToPool(_storagePoolId); -- To view, visit http://gerrit.ovirt.org/22045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55cd5aa6a6dc32f374a4bb21b159d3cb30da65f5 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
