Allon Mureinik has posted comments on this change. Change subject: core: prevent maintenance when domain is still in use ......................................................................
Patch Set 12: (1 comment) Juan - can you take a look at the REST parts please? Daniel - same question regarding frontent. http://gerrit.ovirt.org/#/c/22045/12/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java: Line 209: for (VDS vds : DbFacade.getInstance().getVdsDao().getAllForStoragePool(storagePoolId)) { Line 210: if (vds.getStatus() == VDSStatus.Up Line 211: || vds.getStatus() == VDSStatus.NonResponsive Line 212: || vds.getStatus() == VDSStatus.PreparingForMaintenance Line 213: || vds.getStatus() == VDSStatus.NonOperational) { > Can we add a method to the VDSStatus isConnected or something and just use +1. Line 214: vdsNotInMaintenance.add(vds.getId()); Line 215: } Line 216: } Line 217: -- To view, visit http://gerrit.ovirt.org/22045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55cd5aa6a6dc32f374a4bb21b159d3cb30da65f5 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
