Martin Sivák has posted comments on this change. Change subject: engine: Refactor AuditLog severity handling - step 1 ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24441/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java: Line 916: static AuditLogSeverity getSeverityForMessage(AuditLogType messageType) { Line 917: AuditLogSeverity severity = severities.get(messageType); Line 918: if (severity == null) { Line 919: severity = AuditLogSeverity.NORMAL; Line 920: log.warnFormat("AuditLogType: {0} not have severity. Assumed Normal", > I think we can skip this noise if we enable to have this as a default , let The second patch removes this. I wanted to see the warnings to get the list of undefined severities here. Line 921: messageType.toString()); Line 922: } Line 923: return severity; Line 924: } -- To view, visit http://gerrit.ovirt.org/24441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c784a2f63d1c1d194f8f6712a39fa18a21b17da Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
