Martin Peřina has posted comments on this change. Change subject: engine: Refactor AuditLog severity handling - step 1 ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/24441/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java: Line 936: Line 937: private int intValue; Line 938: // indicates time interval in seconds on which identical events from same instance are suppressed. Line 939: private int eventFloodRate; Line 940: private static final Map<Integer, AuditLogType> mappings = new HashMap<Integer, AuditLogType>(); > Please move this init into static {}, so it's on one place. Please ignore comment, it's not part of patch Line 941: private AuditLogSeverity severity; Line 942: Line 943: static { Line 944: for (AuditLogType logType : values()) { -- To view, visit http://gerrit.ovirt.org/24441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c784a2f63d1c1d194f8f6712a39fa18a21b17da Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
