Yedidyah Bar David has posted comments on this change. Change subject: core: print environment diff based on str conversion ......................................................................
Patch Set 3: (1 comment) Nice, thanks! http://gerrit.ovirt.org/#/c/23517/3/src/otopi/context.py File src/otopi/context.py: Line 460: value = str(self.environment[key]) Line 461: Line 462: if ( Line 463: old is None or Line 464: value != str(old.get(key)) You run 'str' twice for all the existing values. Not that important :-) Line 465: ): Line 466: if not diff: Line 467: diff = True Line 468: self.logger.debug('ENVIRONMENT DUMP - BEGIN') -- To view, visit http://gerrit.ovirt.org/23517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15969681d8fab57e326a7977a5ed0703d4e9fbd7 Gerrit-PatchSet: 3 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
