Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Permissions of group are not inherited when adding a user
......................................................................
core: Permissions of group are not inherited when adding a user
When adding a user, the group_ids column at the users table
is not modified, so all the related stored procedures that
calculate the permissions do not calculate the correct set of
permissions.
Change-Id: I47caf474fe9acfce26e6232a51918849d970f4cb
Signed-off-by: Yair Zaslavsky <yzasl...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/93/24493/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java
index 7d0017b..aa3e290 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java
@@ -6,6 +6,7 @@
import org.ovirt.engine.core.authentication.Directory;
import org.ovirt.engine.core.authentication.DirectoryManager;
import org.ovirt.engine.core.authentication.DirectoryUser;
+import org.ovirt.engine.core.authentication.DirectoryUtils;
import org.ovirt.engine.core.common.AuditLogType;
import org.ovirt.engine.core.bll.utils.PermissionSubject;
import org.ovirt.engine.core.common.VdcObjectType;
@@ -92,12 +93,16 @@
if (dbUser == null) {
dbUser = new DbUser(directoryUser);
dbUser.setId(Guid.newGuid());
+ String groupIds =
DirectoryUtils.getGroupIdsFromUser(directoryUser);
+ dbUser.setGroupIds(groupIds);
dao.save(dbUser);
}
else {
Guid id = dbUser.getId();
dbUser = new DbUser(directoryUser);
dbUser.setId(id);
+ String groupIds =
DirectoryUtils.getGroupIdsFromUser(directoryUser);
+ dbUser.setGroupIds(groupIds);
dao.update(dbUser);
}
--
To view, visit http://gerrit.ovirt.org/24493
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I47caf474fe9acfce26e6232a51918849d970f4cb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
