Fabian Deutsch has posted comments on this change. Change subject: engine_page: use vdsm to detect mgmt interface ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/24417/5/src/engine_page.py File src/engine_page.py: Line 47: cfg = VDSM().retrieve() Line 48: networks = netinfo.networks() Line 49: Line 50: mgmtIface = [] Line 51: for net in networks: Is networks a dict? If so - don't we loop through the values then, and not the keys? If we want to loop through keys we need: networks.keys() Line 52: if net in ('ovirtmgmt', 'rhevm'): Line 53: if 'bridge' in networks[net]: Line 54: mgmtIface = [networks[net]['bridge']] Line 55: else: -- To view, visit http://gerrit.ovirt.org/24417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e1b69c0f465f1e38779e451777cae67bd4cde40 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Joey Boggs <[email protected]> Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
