Fabian Deutsch has posted comments on this change. Change subject: engine_page: use vdsm to detect mgmt interface ......................................................................
Patch Set 3: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/24417/3/src/engine_page.py File src/engine_page.py: Line 57: if 'rhevm' in nets: Line 58: if 'bridge' in nets['rhevm']: Line 59: mgmtIface = [nets['rhevm']['bridge']] Line 60: else: Line 61: mgmtIface = [nets['rhevm']['iface']] You could have kept the loop, to not have the duplicate code - but up to you :) Line 62: Line 63: mgmt = Management() Line 64: mgmt.update( Line 65: "oVirt Engine http://%s:%s"; % (cfg["server"], -- To view, visit http://gerrit.ovirt.org/24417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e1b69c0f465f1e38779e451777cae67bd4cde40 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@fedoraproject.org> Gerrit-Reviewer: Joey Boggs <jbo...@redhat.com> Gerrit-Reviewer: Ryan Barry <rba...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
