Liron Ar has posted comments on this change. Change subject: core: Fix event message when removing a LUN disk ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/24163/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java: Line 319: switch (getActionState()) { Line 320: case EXECUTE: Line 321: if (getDisk().getDiskStorageType() == DiskStorageType.LUN) { Line 322: return getSucceeded() ? AuditLogType.USER_FINISHED_REMOVE_DISK_NO_DOMAIN Line 323: : AuditLogType.USER_FINISHED_FAILED_REMOVE_DISK_NO_DOMAIN; lun disks removal can't fail actually in the execute part, as it's a simple removal from the db..but i don't mind having it for the future in case we'll add ops that might fail. Line 324: } Line 325: else { Line 326: return getSucceeded() ? AuditLogType.USER_FINISHED_REMOVE_DISK Line 327: : AuditLogType.USER_FINISHED_FAILED_REMOVE_DISK; Line 321: if (getDisk().getDiskStorageType() == DiskStorageType.LUN) { Line 322: return getSucceeded() ? AuditLogType.USER_FINISHED_REMOVE_DISK_NO_DOMAIN Line 323: : AuditLogType.USER_FINISHED_FAILED_REMOVE_DISK_NO_DOMAIN; Line 324: } Line 325: else { no need for the else clause, because you always return regardless, the else should move one line up Line 326: return getSucceeded() ? AuditLogType.USER_FINISHED_REMOVE_DISK Line 327: : AuditLogType.USER_FINISHED_FAILED_REMOVE_DISK; Line 328: } Line 329: default: -- To view, visit http://gerrit.ovirt.org/24163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7624619d27e9e9fd6ffdc09f4380b9d2dbe5624b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
