Sergey Gotliv has posted comments on this change. Change subject: core: Fix event message when removing a LUN disk ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24163/2/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 112: USER_MOVED_VM_DISK_FINISHED_FAILURE=User ${UserName} have failed to move disk ${DiskAlias} to domain ${StorageDomainName}. Line 113: USER_FINISHED_REMOVE_DISK=Disk ${DiskAlias} was successfully removed from domain ${StorageDomainName} (User ${UserName}). Line 114: USER_FINISHED_FAILED_REMOVE_DISK=Disk ${DiskAlias} was successfully removed from domain ${StorageDomainName} with storage failure (User ${UserName}). Line 115: USER_FINISHED_REMOVE_DISK_NO_DOMAIN=Disk ${DiskAlias} was successfully removed (User ${UserName}). Line 116: USER_FINISHED_FAILED_REMOVE_DISK_NO_DOMAIN=Disk ${DiskAlias} was successfully removed with storage failure (User ${UserName}). > You sure that was not the original intention? I just copied the message fro Yes, I sure. Ask Nir, it was a failure, the disk wasn't removed. Line 117: USER_ATTACH_DISK_TO_VM=Disk ${DiskAlias} was successfully attached to VM ${VmName} by ${UserName}. Line 118: USER_FAILED_ATTACH_DISK_TO_VM=Failed to attach Disk ${DiskAlias} to VM ${VmName} (User: ${UserName}). Line 119: USER_DETACH_DISK_FROM_VM=Disk ${DiskAlias} was successfully detached from VM ${VmName} by ${UserName}. Line 120: USER_FAILED_DETACH_DISK_FROM_VM=Failed to detach Disk ${DiskAlias} from VM ${VmName} (User: ${UserName}). -- To view, visit http://gerrit.ovirt.org/24163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7624619d27e9e9fd6ffdc09f4380b9d2dbe5624b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
