Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: legacy: db: parse pgpass file with escapes ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/24407/3/packaging/setup/plugins/ovirt-engine-setup/legacy/database.py File packaging/setup/plugins/ovirt-engine-setup/legacy/database.py: Line 80: if escape: Line 81: escape = False Line 82: s += c Line 83: else: Line 84: if (c == ':' and colon_counter < 4) or c == '\n': please replace counter with len(d) ? Line 85: if c == ':': Line 86: colon_counter += 1 Line 87: d.append(s) Line 88: s = '' -- To view, visit http://gerrit.ovirt.org/24407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4727d1c926cefa44c3a98382983126b8f9873051 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: James W. Mills <jami...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
