Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: legacy: db: parse pgpass file with escapes ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/24407/3/packaging/setup/plugins/ovirt-engine-setup/legacy/database.py File packaging/setup/plugins/ovirt-engine-setup/legacy/database.py: Line 68: 'r', Line 69: ) as f: Line 70: for l in f: Line 71: # There are four ":" field seperators. Anything Line 72: # else is part of a password. are you sure? it is not based on documentation[1] [1] http://www.postgresql.org/docs/9.1/static/libpq-pgpass.html Line 73: colon_counter = 0 Line 74: if l and l[-1] != '\n': Line 75: l += '\n' Line 76: d = [] -- To view, visit http://gerrit.ovirt.org/24407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4727d1c926cefa44c3a98382983126b8f9873051 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: James W. Mills <jami...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
